keep re-render issue for custom hook - useEffect, fixed by useMemo to wrap object

solution is:

for object, need wrap with useMemo in this case, if function, need wrap with useCallback

const accountRoles = useMemo(() => account?.roles || [], [])

issue was in listing.tsx

const accountRoles = account?.roles || [], []
const [todoDocs] = useListingTodoDocs(listingId, accountRoles, false)

in useListingTodoDocs, ulilize useEffect to fetch data, acccountRoles is object, so always 
change and trigger useEffect action. 

useEffect(() => {
    const fetchListingTodos = async () => {
      const result = await client.query({
        query: GET_TODO_DOCUMENTS,
        variables: { listingId: listingId },
        fetchPolicy: 'no-cache',
      })

      const {
        data: { getTodoDocuments },
      } = result

      const filterTodosByRole =
        accountRoles.length === 0
          ? getTodoDocuments.filter(
              (doc: Document) =>
                !doc.name.includes(LISTING_AGREEMENT_BROKER_SIGNATURE)
            )
          : getTodoDocuments

      dispatch({
        type: 'fetchListingTodosSuccess',
        payload: filterTodosByRole,
      })
    }
    fetchListingTodos()
  }, [refreshFlag, client, listingId, accountRoles])


  

Comments

for loop in javascript - promise - .eslintrc for "for of"

the vast majority of cases map , forEach , find etc. can be used. async function printFiles () { const files = await getFilePaths(); await Promise.all(files. map (async (file) => { const contents = await fs.readFile(file, 'utf8') console.log(contents) })); } const inventory = [ { name : 'apples' , quantity : 2 } , { name : 'bananas' , quantity : 0 } , { name : 'cherries' , quantity : 5 } ] ; const result = inventory . find ( ( { name } ) => name === 'cherries' ) ; function getFirstMatching(array) { for (let item of array) { const result = heavyTransform(item); if (result) { return result; } } } Specifically this shuts down the whole no-restricted-syntax. If you want to cherry-pick, here is the current definition: 'no-restricted-syntax' : [ 'error' , { selector : 'ForInStatement' , message...

Apollo client - cache APIs - auto update cache - erase cache - reactive variables - deletion - addition

Apollo Client 3 Local only fields Reactive Variables const cache = new InMemoryCache ( { typePolicies : { Todo : { // If one of the keyFields is an object with fields of its own, you can // include those nested keyFields by using a nested array of strings: keyFields : [ "date" , "user" , [ "email" ] ] , } } , } ) ; This internal data is intended to be easily JSON-serializable , so you can take a snapshot with cache.extract() , save it somewhere, and later restore with cache.restore(snapshot) . Here’s a mutation called EditTodo that returns the new todo value in the mutation response. mutation EditTodo ( $id : Int ! , $text : String ! ) { editTodo ( id : $id , text : $text ) { success todo { # <- Returning it here id text completed } error { ... on TodoNotFoundError { message } ... on TodoValidationE...

window.URL.createObjectURL is not (yet) available in jest-dom - testing scenario

Since window.URL.createObjectURL is not (yet) available in jest-dom, you need to provide a mock implementation for it. Don't forget to reset the mock implementation after each test. describe ( "your test suite" , () => { window . URL . createObjectURL = jest . fn (); afterEach (() => { window . URL . createObjectURL . mockReset (); }); it ( "your test case" , () => { expect ( true ). toBeTruthy (); }); });

Andmapco - dev team

Search This Blog